Repository navigation
fix(hub): log the cause of failures the hub swallowed - #218
Merged
Merged
Conversation
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/hub/src/request-error.ts:16-20 nested-ternary: Nested ternary; use if statements or a lookup.
- Errors kept: added code matches a code pattern
apps/hub/src/builds/posix-sandbox.ts:999-1002 bare-catch: A catch without a binding drops the error; check for the expected failure, or catch it and rethrow the rest.
|
Triage: Unsure Asking a maintainer about:
|
corbits-triage
Bot
dismissed stale reviews from themself
November 7, 2026 04:42
Nothing triage asked to change still fails, so this request no longer stands.
Seven places caught every error and carried on. Each now treats only its expected failure as normal and logs anything else with its error code: credential refresh, the pushed ref, the pre-write file check, auth emails, workflow connection sync, migrations and the preview reload. errorCode reads a wrapped error's cause, so Drizzle failures carry their code.
TheGreatAxios
force-pushed
the
cl-12104-stop-the-hub-hiding-its-own-failures
branch
from
November 7, 2026 04:52
a80b333 to
7ef4a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When something failed in seven places in the hub, it was silently ignored and nobody could tell why. Now each failure is logged with its error code. The message is left out, so no secrets leak. What the app does is unchanged.
Links CL-12104.
Verified
mainand passes here. It checks that the error code is printed and the database URL is not.