Repository navigation
refactor(hub): drop provisioner-side sidecar fences - #217
Merged
Merged
Conversation
Interchange mints a new sidecar identity for every ensure and never re-ensures a generation after destroying it. Both provisioners run inside the hub and already order ensure before destroy, so the fences guarded against requests that cannot arrive.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Both sidecar provisioners (the local process and Docker) kept "fences": a record of deleted deployments, used to refuse a late request to create one again. That request never reaches them. Interchange mints a new sidecar identity for every create and never re-creates a version it deleted. Both provisioners run inside the hub and already handle create and delete for a deployment in order. So the fences, the
fences.jsonfile and the database check that pruned it are removed.One small behaviour change: a repeated delete for a sidecar id nothing ran on now answers that cleanup is done, so Interchange retires that unused id.
How it was verified
bun run lint,format:check,typecheck,test(325 pass),pins:verify,vendor:verify