Repository navigation
fix(hub): give the coder's sandbox a bun shim to the hub's Bun - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coder's sandbox now writes a
bunshim next to its existingnodeshim. Both run the hub's own Bun by its full path. Before this,bunresolved only if the hub's Bun binary was namedbun. A hub started with Bun from npm, which ships it asbun.exe, failed every build command and the Live Preview install with exit code 127.Verified by creating the sandbox the way the hub does and running
bun --versionandbun installin it, under Bun 1.4.4 installed from npm. On main both commands exit 127 in 3 of 3 runs. With this changebun --versionprints 1.4.4 in 3 of 3 runs, matching a control run with Bun from the official install script. Lint, format, typecheck, pins, vendor checks and the full test suite pass.Fixes CL-12207