Skip to content

fix(web): retry the first session check and read it once - #215

Closed
TheGreatAxios wants to merge 4 commits into
mainfrom
cl-12203-recover-from-a-failed-first-session-check-without-a
Closed

TheGreatAxios wants to merge 4 commits into
mainfrom
cl-12203-recover-from-a-failed-first-session-check-without-a

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

If the hub doesn't answer the "who is signed in?" check when the page loads, the interface now keeps trying and opens by itself once the hub is back. Before, someone signed in was stuck on the loading screen until they reloaded.

The shell and the invitation screen now share that one check, so it's asked once per load instead of two or three times.

Closes CL-12203.

@linear-code

linear-code Bot commented Nov 6, 2026

Copy link
Copy Markdown

CL-12203

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Before and after, signed in, 45 seconds after the session check was unblocked (no reload):

Before After
before after

Before, the loading screen stays. After, the page has moved on by itself. This test account has no model key yet, so it lands on model setup.

This stays a draft until #213 and #214 merge; it will be rebased onto them, keeping the session answer when the cache is cleared on sign-out.

@TheGreatAxios
TheGreatAxios force-pushed the cl-12203-recover-from-a-failed-first-session-check-without-a branch from 3b6f3a0 to bc89eff Compare November 6, 2026 22:56
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 6, 2026 22:56

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/web/src/App.tsx:558-562 nested-ternary: Nested ternary; use if statements or a lookup.

@TheGreatAxios
TheGreatAxios force-pushed the cl-12203-recover-from-a-failed-first-session-check-without-a branch from bc89eff to 332381b Compare November 6, 2026 23:04
@corbits-triage
corbits-triage Bot dismissed their stale review November 6, 2026 23:10

Nothing triage asked to change still fails, so this request no longer stands.

Comment thread apps/web/src/App.tsx Resolved
Comment thread apps/web/src/App.tsx Resolved
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 6, 2026
@TheGreatAxios
TheGreatAxios marked this pull request as draft November 6, 2026 23:12
@corbits-triage
corbits-triage Bot dismissed their stale review November 6, 2026 23:13

This pull request is no longer ready to approve, so this approval no longer stands.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Closing as needs further research. When the session check fails on page load with a 429, a 403, or a non-JSON reply, this PR shows the sign-in screen to someone who may still be signed in. main shows a loading screen in those cases instead. Reproduced in the browser 2/2 for each case. The findings and open questions are on CL-12203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant