Skip to content

fix(hub): ship workspaces with no reviewers - #203

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-12166-ship-workspaces-with-no-reviewers-and-keep-the-demo-personas
Nov 6, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-12166-ship-workspaces-with-no-reviewers-and-keep-the-demo-personas

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Every new workspace came with three made-up saved reviewers (Dana Chen, Marcus Vance, Priya Patel), shown in Settings and offered when sharing an approval package. The share dialog also suggested "Dana Chen" as a name. Now a new workspace has no saved reviewers, and the name field just says "Reviewer name". The three personas stay available for demos through the seed script.

Before: three made-up reviewers. After: none

Verification

  • Main: the personas show in every new workspace (2 fresh browsers, and the click-through).
  • This branch: "No saved workspace reviewers yet.", no saved picker in the share dialog, and the placeholder reads "Reviewer name" (2 fresh browsers, and the click-through).
  • Seeding a dev workspace with no saved reviewers adds the three personas; a workspace that already has its own list keeps it.
  • Workspaces that already saved the personas keep them (people can remove them).
  • Lint, format, typecheck, tests, pins and vendor checks pass.

Closes CL-12166

A workspace that never saved reviewers fell back to three demo personas,
held as a default in both the hub and the interface. Both now default to
an empty list, and the personas live in the seed data, which dev:seed
writes to a workspace that has no saved reviewers. The share dialog's
name placeholder no longer names one of them.
@linear-code

linear-code Bot commented Nov 6, 2026

Copy link
Copy Markdown

CL-12166

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Conventions: added code matches a code pattern
    • apps/hub/src/artifacts/approval-rounds.ts:476 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.

@corbits-triage

corbits-triage Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@corbits-triage
corbits-triage Bot dismissed their stale review November 6, 2026 04:18

Nothing triage asked to change still fails, so this request no longer stands.

Comment thread scripts/seed-projects.ts Resolved
@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 4ac7de2 Nov 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant