Repository navigation
fix(hub): move on after an approval unless the person asks to wait - #199
Merged
Merged
Conversation
|
Merged before Triage finished on |
TheGreatAxios
force-pushed
the
cl-12183-investigate-forgotten-tool-calls
branch
from
November 6, 2026 03:30
66a304b to
3478b6e
Compare
TheGreatAxios
force-pushed
the
cl-12183-investigate-forgotten-tool-calls
branch
2 times, most recently
from
November 6, 2026 05:17
1155f2a to
515a858
Compare
TheGreatAxios
dismissed
corbits-triage[bot]’s stale review
November 6, 2026 05:42
The merge-base changed after approval.
TheGreatAxios
force-pushed
the
cl-12183-investigate-forgotten-tool-calls
branch
from
November 6, 2026 05:42
515a858 to
e1e41fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When someone approved a document, the coordinator often replied "it's ready for approval" and started nothing, so the project sat still until they typed again. Now it moves on by itself, and still waits when the person asks it to.
How it was verified
Replays of real conversations right after an approval:
Two live projects through to the design:
Lint, typecheck and tests pass.
Closes CL-12183