Skip to content

fix(hub): move on after an approval unless the person asks to wait - #199

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-12183-investigate-forgotten-tool-calls
Nov 6, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-12183-investigate-forgotten-tool-calls

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What changed

When someone approved a document, the coordinator often replied "it's ready for approval" and started nothing, so the project sat still until they typed again. Now it moves on by itself, and still waits when the person asks it to.

  • After an approval, the hub tells the coordinator what can start now. The writer, designer and coder each have one gate, the rule they already refuse with, and the approval lists every step whose gate passes and that is not already made or under way. Loosening a gate later loosens what the coordinator is told, so the order lives in one place.
  • If the coordinator then replies without starting anything or asking the person something, it is reminded once. A second reply goes through, so "approve it, but hold off" is respected.

How it was verified

Replays of real conversations right after an approval:

The person said main this PR
"Go with your recommendation" (the original stall) started the next step 0 of 10 10 of 10
"Approve, then hold off" waited 10 of 10 waited 5 of 5
"Looks good, stop here for a sec" waited 10 of 10 waited 5 of 5
"…until I say banana" waited 2 of 2 waited 3 of 3
"Stop." stopped 1 of 2 stopped 3 of 3
"ya kool whatevr" started the next step 1 of 2 3 of 3
"Skip the requirements, go to design" wrote the requirements 1 of 2 3 of 3
Imported project, "add a feature" asked or read first 10 of 10 5 of 5

Two live projects through to the design:

  • OpenAI, with a question right after approving, "don't do anything until I say banana", and "hold off" followed by "actually go": each wish was followed, with no freezes and never more than one writer at a time.
  • xAI, asking to skip constraints, approaches and the design: the coordinator explained what the hub needs and carried on, with no loops or made-up values.

Lint, typecheck and tests pass.

Closes CL-12183

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

CL-12183

@corbits-triage

corbits-triage Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Merged before Triage finished on e1e41fb.

Comment thread apps/hub/src/projects/deploy-tools.ts Resolved
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 6, 2026
@TheGreatAxios TheGreatAxios changed the title fix(hub): start the writer an approval unblocks fix(hub): move on after an approval unless the person asks to wait Nov 6, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-12183-investigate-forgotten-tool-calls branch from 66a304b to 3478b6e Compare November 6, 2026 03:30
Comment thread apps/hub/src/projects/deploy-tools.ts Resolved
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 6, 2026
Comment thread apps/hub/src/workflows/director.ts Resolved
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 6, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-12183-investigate-forgotten-tool-calls branch 2 times, most recently from 1155f2a to 515a858 Compare November 6, 2026 05:17
Comment thread apps/hub/src/projects/deploy-tools.ts Resolved
Comment thread apps/hub/src/workflows/director.ts Resolved
corbits-triage[bot]
corbits-triage Bot previously approved these changes Nov 6, 2026
@TheGreatAxios
TheGreatAxios dismissed corbits-triage[bot]’s stale review November 6, 2026 05:42

The merge-base changed after approval.

@TheGreatAxios
TheGreatAxios force-pushed the cl-12183-investigate-forgotten-tool-calls branch from 515a858 to e1e41fb Compare November 6, 2026 05:42
@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit adf268d Nov 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant