Skip to content

chore(policy): approve maintainers whatever code review finds - #197

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-12181-make-triage-code-review-findings-advisory-for-maintainers
Nov 5, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-12181-make-triage-code-review-findings-advisory-for-maintainers

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-12181

What changed

  • The approve step for the approved group now uses findings: { any: true } instead of { above: P2 }. A passing pull request from that group is approved whatever its code review finds. Code review still runs and posts its findings.
  • Other steps and outside contributors are unchanged: findings is set only on this step, and outside contributors are not in code-review.for.

How it was verified

  • Ran Corbits Triage's checkPolicyFile on the new file: ok: true.
  • Read the manager's gating (openUnder in review-clean.ts): { any: true } holds back no finding of any priority. Approval still waits while the review runs, and is held when the review did not read the whole change.
  • Pre-commit hooks pass (format, lint, typecheck, commit format, no attribution).

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

CL-12181

@corbits-triage

corbits-triage Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit b38aefb Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant