Repository navigation
chore(policy): approve maintainers whatever code review finds - #197
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12181
What changed
approvestep for theapprovedgroup now usesfindings: { any: true }instead of{ above: P2 }. A passing pull request from that group is approved whatever its code review finds. Code review still runs and posts its findings.findingsis set only on this step, and outside contributors are not incode-review.for.How it was verified
checkPolicyFileon the new file:ok: true.openUnderinreview-clean.ts):{ any: true }holds back no finding of any priority. Approval still waits while the review runs, and is held when the review did not read the whole change.