Skip to content

chore(policy): require a linked issue only from outside contributors - #196

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-12179-disable-issue-reference-check-for-maintainers
Nov 5, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-12179-disable-issue-reference-check-for-maintainers

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-12179

What changed

  • Turned off the linked-issue rule, so a pull request with no issue no longer fails for members, collaborators or the approved group.
  • Added an outside group (CONTRIBUTOR, FIRST_TIME_CONTRIBUTOR, FIRST_TIMER, NONE, MANNEQUIN) after approved. Triage puts an author only in the first file group they match, so approved users with a contributor association stay out of it.
  • Outside pull requests with no linked issue get the "open an issue first" comment and are closed on pass, fail and unsure. Closing on unsure still waits for a person.
  • Failing pull requests from members, collaborators, bots and approved get changes requested. Outside ones get it only when they link an issue.

How it was verified

  • Ran Corbits Triage's checkPolicyFile on the new file: ok: true.
  • Ran each verdict through whenHolds, with and without a linked issue:
    • etodanik (MEMBER), pratikbuilds (CONTRIBUTOR, in approved), bwachman (MEMBER): never commented on or closed.
    • Any other CONTRIBUTOR with no issue: comment + close on every verdict.
    • Any other CONTRIBUTOR with an issue: review from code owners on pass, changes requested on fail.
  • Pre-commit hooks pass (format, lint, typecheck, commit format, no attribution).

@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

CL-12179

@corbits-triage

corbits-triage Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@TheGreatAxios TheGreatAxios self-assigned this Nov 5, 2026

@corbits-triage corbits-triage Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No defects reported.

@TheGreatAxios
TheGreatAxios merged commit 10426d5 into main Nov 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant