Repository navigation
fix(hub): stop the hub when it is signalled during startup - #192
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:38
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 02:50
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:51
corbits-triage
Bot
added
Triage: Needs Human Review
and removed
Triage: Not Ready
labels
A stop during startup ran the shutdown before anything existed to close, and startup then bound the port and stayed up. A stop signal during startup is now recorded and acted on once startup finishes, and startup skips binding the port when a stop is pending, so the stop closes what startup opened and the process exits. A fatal error still shuts down at once without waiting for startup.
TheGreatAxios
force-pushed
the
cl-12159-stop-the-hub-when-it-is-signalled-during-startup
branch
from
November 5, 2026 02:59
5f68744 to
b33b61a
Compare
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 03:06
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
dismissed
their stale review
November 5, 2026 03:09
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
deleted the
cl-12159-stop-the-hub-when-it-is-signalled-during-startup
branch
November 5, 2026 03:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SIGTERM or SIGINT during startup is now recorded and acted on once startup finishes, so the shutdown closes what startup opened. Startup skips
Bun.serve,runtime.start()and "Hub ready" once a stop has been requested. A fatal error still shuts down at once without waiting for startup, so the supervisor restarts the hub. Before, the first signal ran the shutdown with nothing to close and returned, and startup went on to bind the port and stay up.Fixes CL-12159.
Verification
Against a real hub on throwaway Postgres databases, with SIGTERM sent once
pg_stat_activityshowed startup held on atenanttable lock:No log contained a database URL.
bun run lint,format:check,typecheckandtest(290 pass) pass.