Repository navigation
fix(hub): give every agent a read_file for trimmed results - #191
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:38
A trimmed result's note, and the size cap's, tell the agent to read_file a tool-output URI, but the coordinator, writer, reviewer and presenter had no read_file, so they could not get a trimmed document read back. They now get a read_file of the agent's saved results that reads only tool-output URIs, so it opens no files, and the coder and designer now share this same reader.
TheGreatAxios
force-pushed
the
cl-12156-let-every-agent-recover-a-trimmed-result-with-a-tool-it-has
branch
from
November 5, 2026 03:09
a3cbdb7 to
36001af
Compare
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 03:11
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
deleted the
cl-12156-let-every-agent-recover-a-trimmed-result-with-a-tool-it-has
branch
November 5, 2026 03:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trimmed history and Interchange's size cap both tell an agent to
read_fileatool-output:///URI, but the coordinator, presenter, reviewer and writers had noread_file. A newsavedResultTools(apps/hub/src/workflows/saved-result-tools.ts) wraps Interchange's posixread_filewith the storage blob reader and accepts onlytool-output://URIs, so agents without a workspace gain no file access. Each of those entries gets it, and the coder sidecar uses it for its owntool-output://reads in place of an inline reader. A URI with a dropped slash is repaired, because the URI parser reads the call id as a host.Fixes CL-12156.
Verification
A real hub, sidecar, coordinator package, history trimming and tool grants. The model was a scripted OpenAI-compatible server that read a skill, then called
read_filewith the URI from the trimming note.read_fileofferedNo matching grants for tool:read_file/invokeOnly the coordinator ran live;
packaged.test.tschecks that every entry offersread_file. The size-cap path was not run live.bun run lint,format:check,typecheck,test(291 pass),pins:verifyandvendor:verifypass.