Repository navigation
fix(hub): withdraw an outdated coordinator's approval on the open page - #189
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Conversation
Approval parks leave the correlation id field empty, so the once-per-park check compared nothing to nothing and never replaced the coordinator; the question stayed up until the regular pass and an answer landed on the old coordinator. Key the check on the signal name every park carries.
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:31
corbits-triage
Bot
added
Triage: Needs Human Review
and removed
Triage: Waiting for code review
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 02:41
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
deleted the
cl-12147-withdraw-an-outdated-coordinators-open-approval-before-the
branch
November 5, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversation route's once-per-park guard now keys on the park's
signalNameinstead ofcorrelationId. Interchange never fillscorrelationIdon an approval park'sSignalAwaited, so the guard never fired. An outdated coordinator's approval stayed up until the 30-second reconcile pass, and an answer in that window landed on the old coordinator.signalNameis required on every park and embeds the approval's unique correlation id.Fixes CL-12147.
Verification
A throwaway route test, deleted afterwards, served an approval park with only
signalNameand requested the events route twice:upgradecallsbun run lint,format:check,typecheckandtest(290 pass) pass.