Repository navigation
fix(hub): refuse a read of an attachment the person removed - #188
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Waiting for the decision model
and removed
Triage: Waiting for CI
labels
TheGreatAxios
marked this pull request as draft
November 5, 2026 02:31
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 02:36
|
Merged before Triage finished on |
Removing an attachment archives it, and lists already leave it out, but a read by id still returned its content. A coordinator that kept the id from an earlier read could still quote the withdrawn file. A removed attachment now reads as not found, the same as a missing one.
TheGreatAxios
force-pushed
the
cl-12153-refuse-a-read-of-an-attachment-the-person-removed
branch
from
November 5, 2026 02:39
4471acb to
686e6cb
Compare
TheGreatAxios
deleted the
cl-12153-refuse-a-read-of-an-attachment-the-person-removed
branch
November 5, 2026 02:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The artifact service's
readnow answersartifact_not_foundfor an archived row. Removing an attachment archives it; lists already left it out, but a read by id still returned its content. Every read by id (the artifact route,read_artifact, pinnedid@v#sha) goes through this check. OnlyremoveMaterialarchives artifacts, so no other kind is affected.Fixes CL-12153.
Verification
A throwaway end-to-end run against the real hub on a scratch Postgres, which imported a project with two materials and removed one:
bun run lint,format:check,typecheckandtest(290 pass) pass.