Repository navigation
docs: stamp new migrations after 0038 until its date passes - #187
Merged
TheGreatAxios merged 1 commit intoNov 5, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
0038 is stamped 8 November 2026 and databases that applied it keep that stamp, so it stays. Until then, a generated migration sorts before it and needs its stamp set one past the previous entry's.
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 01:50
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Waiting for the decision model
Triage: Waiting for code review
and removed
Triage: Waiting for the decision model
labels
TheGreatAxios
enabled auto-merge
November 5, 2026 01:51
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
deleted the
cl-12148-keep-the-next-migration-from-being-skipped-after-the
branch
November 5, 2026 01:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Migrations section to
docs/DEV.md. Create migrations withbun run db:generate, and never move a mergedwhen. Until 8 November 2026 01:06:40 UTC, a generated migration sorts before 0038, so set itswhento one more than the previous entry's. 0038's stamp is unchanged, because databases that applied it keep that value.Fixes CL-12148.
Verification
Against throwaway Postgres databases, with
apps/hub/src/migrate.ts:sb_approval_round.migrate.test.tsfails.bun run lint,format:check,typecheck,test,pins:verifyandvendor:verifypass.