Repository navigation
feat: ask to choose a design through an approval card - #186
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
The coordinator now asks for the design with choose_design, a native approval, and the existing approval card carries the buttons. The separate Confirm prompt, its client call and its wording are removed.
A choose_design approval covers the concept, so a look tweak saved while the card is open is filed with the design. The approval lock, the design write and both approval records share one transaction, and a reused approval is refused as approval_already_used. A refused choice tells the coordinator to ask again, and the card says approved only once the design is recorded. The concept link shows only while the card is pending and the concept has a tab.
TheGreatAxios
marked this pull request as ready for review
November 5, 2026 00:45
|
Triage: Unsure Asking a maintainer about:
|
Contributor
Author
|
Closing for now while today's merges are stabilised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coordinator now asks the person to choose a design with a new choose_design tool, declared as a native approval, so the choice shows on the existing approval card with its own buttons and, while the card is pending and the concept's tab is open to it, a link to the concept's mockup. The separate Confirm prompt under the coordinator's reply, its component, its client call, its styles and its wording are removed, and the design-choice route is now called only by the coordinator's tool.
A choose_design approval covers the concept, not one version, so a look tweak the person saves while the card is open is filed with the design instead of failing the choice. The hub locks the approval, files the concept's newest option as the design and records the approval against both the option and design versions in one transaction, so a failure leaves the approval unused and nothing filed. Each approval chooses once; reusing one is refused with approval_already_used, and an approval of another concept with approval_not_resolved. When the hub refuses a choice, the tool result tells the coordinator that no design was filed and to ask the person again. The settled card says "Approved" only once the hub has recorded the filed design; until then it reads "Chosen · the X design, not filed yet". The seed script still imports its fixture projects, chosen design included, as the person's own import, and the import approval table comment now says so.
The recorded replay's coordinator exchanges 23 and 24 were edited by hand rather than re-recorded: re-recording needs the original live-model run's stored workflow runs, which are not available here. test/e2e/support/extract.ts is updated so a regeneration emits the same choose_design call and its result check.
Verified with lint, format:check, typecheck, bun run test, pins:verify, vendor:verify and the full e2e suite against a throwaway Postgres. A new e2e test, design-choice.test.ts, covers an approval that cannot be reused, a refused wrong concept, and a tweak saved while the card is open being filed. Unit tests cover the card's link and settled line and the coordinator's ask-again refusal. The recorded pipeline replay approves choose_design and the build plan still waits on the approved design.
Closes CL-12142