Repository navigation
fix(web): keep a document link inline in the coordinator's sentence - #183
Merged
TheGreatAxios merged 2 commits intoNov 4, 2026
Conversation
Contributor
Author
|
Real
|
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 23:25
TheGreatAxios
enabled auto-merge
November 4, 2026 23:25
|
Merged before Triage finished on |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-12088-keep-a-document-link-inline-in-the-coordinators-sentence
branch
from
November 4, 2026 23:45
f725bb9 to
f53ceb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A document name in a conversation reply rendered as a button styled with inline-flex, a 44px minimum height and side padding. A button is laid out as one unbreakable box, so the title dropped onto its own line, the line grew taller and the punctuation after it stood apart. The name now renders as an inline link that wraps with the sentence and still opens the document on click. The print view no longer needs to spare the mention when it strips buttons.
Verified with a new transcript test that checks the bold title is an inline link with the period attached and that clicking it opens the document, plus before and after screenshots of the real conversation component at full and narrow widths in headless Chromium. Lint, format check, typecheck, the test suite, pins:verify and vendor:verify pass.
Closes CL-12088