Repository navigation
fix(hub): fail the design check when a design file cannot be read - #182
Merged
Merged
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 23:22
TheGreatAxios
enabled auto-merge
November 4, 2026 23:22
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
There was a problem hiding this comment.
Triage requests changes:
- Invented fallbacks: added code matches a code pattern
apps/hub/src/builds/design-check.ts:158 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.apps/hub/src/builds/design-check.ts:161 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design check fingerprints the mockup files to decide whether its last result still applies. Any failure to list or read those files was replaced with an empty value, so an unreadable file dropped out of the fingerprint and a stale "check passed" could be reused and filed for files the check never saw. Now only a missing file or folder counts as empty; any other failure is returned to the check_design and file_design_option tools as an error.
A new unit test makes a design screen unreadable and shows the check now rejects with EACCES without running check-app; it failed before the change. Lint, format check, typecheck, bun run test (289 pass), pins:verify and vendor:verify all pass.
Refs CL-12109