Repository navigation
refactor(hub): share one package source pin and excluded-kind check - #180
Merged
Merged
Conversation
TheGreatAxios
enabled auto-merge
November 4, 2026 23:05
|
Triage: In progress Triage is waiting for CI to finish before it decides. This comment shows the verdict once it has. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approval packages had three copies of the source pin check and two inline excluded-kind checks. They now share
verifySourcePinandEXCLUDED_PACKAGE_SOURCE_KINDS.One behaviour change: recording an assignment now refuses
appandapproval_packagesources straight away withexcluded_package_source_kind, instead of only when the package is validated.Verified with lint, format:check, typecheck, test (287 pass), pins:verify and vendor:verify.
Refs CL-11978