Repository navigation
fix(hub): show a received message before the coordinator saves it - #176
Merged
TheGreatAxios merged 1 commit intoNov 4, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-12081-show-a-sent-message-after-a-reload-while-the-coordinator-is
branch
from
November 4, 2026 22:42
7ff5f0c to
80dab3d
Compare
Contributor
Author
|
Checked on a throwaway stack with a model that replies after 12s: send a message, reload mid-reply, reload again after the reply. On main the message was missing mid-reply in 2/2 rounds; on this branch it showed once in 3/3 rounds and the saved copy replaced it without a duplicate (gist).
|
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 22:48
TheGreatAxios
enabled auto-merge
November 4, 2026 22:48
|
Merged before Triage finished on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12081
After a reload, the conversation's turns came only from the coordinator's saved conversation, which saves the person's message together with its reply, so the message was missing until the reply arrived. The run's event log already holds the message as soon as it is received, in a SignalReceived event carrying the mail.
The hub now adds a person's received mail to the turns while no saved person turn is as late as its receipt, reading its text the same way as the saved copy, and drops it once the coordinator saves the message. Mail from workflow runs and non-mail signals such as approval decisions are left out.
Verified with a unit test of the projection (a received message reads as a turn until a saved copy exists, run mail is ignored) and with lint, format:check, typecheck, test and pins:verify.