Repository navigation
fix(hub): log fatal errors and exit so the supervisor restarts the hub - #175
Merged
TheGreatAxios merged 2 commits intoNov 4, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 22:40
TheGreatAxios
enabled auto-merge
November 4, 2026 22:43
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
force-pushed
the
cl-12103-log-the-hubs-fatal-errors-and-restart-it-instead-of-leaving
branch
from
November 4, 2026 22:54
4373b96 to
3a407b8
Compare
Contributor
Author
|
Fixed in 3a407b8: the shutdown IIFE in apps/hub/src/server.ts is now a named |
|
Merged before Triage finished on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12103
The hub now handles unhandled rejections and uncaught exceptions: it logs them through its logger with only the error code, type and in-repo locations, runs its shutdown once, and exits with code 1. A failing shutdown step is logged and marks the exit non-zero instead of rejecting, and the startup failure log uses the same safe metadata instead of the raw error. The hub service in deploy/compose.yml gets restart: unless-stopped so Compose brings it back; the sidecar is spawned by the hub and has no service of its own there.
Verified by running apps/hub/src/server.ts with a preloaded script that rejects or throws an error carrying a database URL with a password. Before the change Bun printed the raw error with the password and the startup log carried the raw error; after it the process exits 1 with one logger line and no password, repeated several times. Lint, format check, typecheck, tests, pins:verify and vendor:verify pass.