Repository navigation
test(hub): check the Codex content-type repair against a real server - #173
Merged
Merged
Conversation
The test stubbed the global fetch before importing the adapter, so it failed whenever code-mode.test.ts imported the adapter first in the same process, as it does on CI.
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 22:38
|
Merged before Triage finished on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12134
The Codex adapter test failed intermittently on main (runs 41895349766 and 41925131923, and branch runs) with a null Content-Type. It replaced the global fetch with a stub before importing the adapter, but since b99954e (#124) code-mode.test.ts also imports the adapter; when that file runs first in the same process, the repair wraps the original fetch and the test's stub bypasses it.
The test now imports the adapter normally and sends the request to a local Bun server that answers without a Content-Type, so it exercises the installed repair whatever order the files run in.
Verified: running code-mode.test.ts before codex-adapter.test.ts failed 4 of 4 times before the change and passes 3 of 3 after, in both orders. lint, format:check, typecheck and the full test suite pass.