Repository navigation
fix(hub): keep the live app running through a failed check or bad line - #166
Merged
TheGreatAxios merged 3 commits intoNov 4, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 20:28
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12101
What changed
apps/hub/src/live-app/host.ts: the once-a-second state check is nowcurrentState(), run throughreportState(). When a check throws, the host logs the error code to stderr and reports a failed state. It no longer exits on an unhandled rejection.apps/hub/src/live-app/runner.ts: the runner reads the host's stdout throughhostReports(). A line that isn't JSON or aHostReportis logged and skipped, and later lines still update the state. Only a failure of the stream itself ends the read.apps/hub/src/live-app/host-report.ts: holdsreportState()andhostReports(), so both can be tested without spawning a host.apps/hub/src/config/live-app.ts: addscheckFailedwording.How it was verified
mainthree times each before changing anything. An error thrown insidesetInterval(async …)exited with code 1. One bad line stopped the read loop.host-report.test.ts: a throwing check reportsfailedand the next check still reports. A bad line between two good ones is skipped, and the state ends on the second good one.bun run lint,format:check,typecheck,test,pins:verifyandvendor:verifyall passed.