Repository navigation
refactor(hub): move the agent director out of the compaction module - #162
Merged
TheGreatAxios merged 1 commit intoNov 4, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 20:25
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Changed since the last verdict (Fail at |
TheGreatAxios
force-pushed
the
cl-12125-move-the-agent-director-out-of-the-compaction-module
branch
from
November 4, 2026 20:30
5f850be to
8de4424
Compare
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12125
The agent director (retries, loop detection and the done gates) moves from
workflows/compaction.tstoworkflows/director.ts, and its tests fromcompaction.test.tstodirector.test.ts.compaction.tskeeps the two compactors,trimHistoryanddropDegenerateTurn, and exports the compactor names the director uses.Behaviour is unchanged. Two moved expressions are rewritten without the nested ternary and the empty-string fallbacks:
isDegeneratereads text and reasoning with filters, and the done gates test a shell command only when the call has one.Verified with lint, format, typecheck, the unit tests (250 pass, director tests unchanged), pins and vendor checks, and
bun run test:e2e(9 pass).