Repository navigation
fix(web): show the attachment tile above the composer - #157
Merged
TheGreatAxios merged 2 commits intoNov 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
The composer scrolled its own overflow at 70vh, which clipped the attachment tray floating above the message box to a sliver. The textarea already caps its height and scrolls, so the composer's scroll no longer kept any control in reach. Drop it, and with it the overflow exceptions for the send-back picker, model list and reviewer notes. Fixes corbitsdev#153
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
Without a cap, the errors, the earlier-document caution and the suggested replies above the box could make the composer taller than a short pane and push the send, stop, attach and mic controls past its edge. Put back the 70vh cap and let those rows give way instead: they share one region that scrolls, so the box below keeps its full height and nothing clips the attachment tray floating above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
What changed
.composerwas a scroll container (max-height: 70vh; overflow-y: auto). The attachment tray (PromptInputFloat) is drawn above the message box withabsolute bottom-full, so that scroll container cut it down to a sliver.The scroll was there to keep the send, stop, attach and mic controls on screen. Only the rows above the box actually need it: the attach and send errors, the earlier-document caution and the suggested replies. The textarea already caps itself at
min(200px, 30vh)and scrolls.This PR:
.composerfrom scrolling but keeps its 70vh cap.composer-notesregion (workspace/index.tsx). That region scrolls once the composer reaches its cap, so the box below keeps its full height, and the attachment tray and model list float above it unclipped.:has(...) { overflow: visible }exceptions that worked around the old clipping. The model-list exception isn't needed without the clip. The.sbpickand.reviewer-stanceexceptions matched nothing: no markup inapps/web/srcuses those classes.The
index.tsxdiff is mostly reindentation from the wrapper.Verification
bun run lint,format:checkandtypecheckpass. The web unit tests pass (104).suggestedRepliesallows) and long text at once. In a full window the composer grew to 505px with nothing scrolling. With the cap forced to 350px (70vh of a 500px window), the notes scrolled as one region, the box kept its 214px, and the tile, attach and send stayed visible. With no notes, the empty region takes no space.