You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): stop thinking while the coordinator waits on an approval - #142
The wait for a reply after sending now ends while the coordinator's run is held on an open approval (parkedOnApproval). An approval card with no reply text no longer leaves "Thinking…" on under it. A standing question does not end the wait, so "Thinking…" stays on between answering it and the stream reporting the run. The condition moved to awaitingReply in live-run.ts so it can be tested. Hub and Interchange unchanged.
How it was verified
bun run lint, format:check, typecheck, pins:verify, vendor:verify: pass
bun test ./apps/web/src: 98 pass, including the new awaitingReply test
Headless Playwright against the real hub and coordinator, on a scripted OpenAI-compatible fake model registered as a custom provider. A MutationObserver recorded every "Thinking…" toggle. Same steps on three UI builds:
Step
origin/main
37a48c1 (first commit)
this PR
Send; coordinator answers with only write_artifact + request_approval
Self-review: awaitingReply keeps the old condition and adds !held, reusing waitingOnPerson, which already covers approvals the coordinator's own run raised and standing questions. sending still shows Thinking before the hub accepts the message. Not checked in the running app.
Correction to my self-review: after 6522085 the reply wait ends only on parkedOnApproval, not waitingOnPerson. A standing question no longer cuts it, so Thinking… stays on between sending an answer and the stream reporting the run.
Screenshots from the headless run: the same turn, where the coordinator answers with only write_artifact + request_approval, with the card open. Timelines for all three builds are in the gist.
origin/main: Thinking… under the card
this PR: no Thinking…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12075
What changed
The wait for a reply after sending now ends while the coordinator's run is held on an open approval (
parkedOnApproval). An approval card with no reply text no longer leaves "Thinking…" on under it. A standing question does not end the wait, so "Thinking…" stays on between answering it and the stream reporting the run. The condition moved toawaitingReplyinlive-run.tsso it can be tested. Hub and Interchange unchanged.How it was verified
bun run lint,format:check,typecheck,pins:verify,vendor:verify: passbun test ./apps/web/src: 98 pass, including the newawaitingReplytestorigin/main37a48c1(first commit)write_artifact+request_approval