Skip to content

fix(web): stop thinking while the coordinator waits on an approval - #142

Merged
brianjfox merged 2 commits into
mainfrom
cl-12075-stop-showing-thinking-while-the-coordinator-waits-on-the
Nov 4, 2026
Merged

brianjfox merged 2 commits into
mainfrom
cl-12075-stop-showing-thinking-while-the-coordinator-waits-on-the

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-12075

What changed

The wait for a reply after sending now ends while the coordinator's run is held on an open approval (parkedOnApproval). An approval card with no reply text no longer leaves "Thinking…" on under it. A standing question does not end the wait, so "Thinking…" stays on between answering it and the stream reporting the run. The condition moved to awaitingReply in live-run.ts so it can be tested. Hub and Interchange unchanged.

How it was verified

  • bun run lint, format:check, typecheck, pins:verify, vendor:verify: pass
  • bun test ./apps/web/src: 98 pass, including the new awaitingReply test
  • Headless Playwright against the real hub and coordinator, on a scripted OpenAI-compatible fake model registered as a custom provider. A MutationObserver recorded every "Thinking…" toggle. Same steps on three UI builds:
Step origin/main 37a48c1 (first commit) this PR
Send; coordinator answers with only write_artifact + request_approval card opens, Thinking stays on (bug) card opens, Thinking off card opens, Thinking off
Answer a standing question in the composer on until reply off for ~200 ms, then on on until reply, no gap
Send a message on until reply flickers off ~200 ms on until reply
Yes, go ahead on until reply, then off same same

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

CL-12075

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Self-review: awaitingReply keeps the old condition and adds !held, reusing waitingOnPerson, which already covers approvals the coordinator's own run raised and standing questions. sending still shows Thinking before the hub accepts the message. Not checked in the running app.

@corbits-triage

corbits-triage Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Comment thread apps/web/src/pages/workspace/index.tsx Resolved

@corbits-triage corbits-triage Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No defects reported.

@brianjfox
brianjfox merged commit cffe98d into main Nov 4, 2026
9 checks passed
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Correction to my self-review: after 6522085 the reply wait ends only on parkedOnApproval, not waitingOnPerson. A standing question no longer cuts it, so Thinking… stays on between sending an answer and the stream reporting the run.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Screenshots from the headless run: the same turn, where the coordinator answers with only write_artifact + request_approval, with the card open. Timelines for all three builds are in the gist.

origin/main: Thinking… under the card this PR: no Thinking…
main fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants