Repository navigation
fix(hub): split writers by document kind and hand off outdated coordinators - #140
Merged
TheGreatAxios merged 5 commits intoNov 4, 2026
Conversation
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 08:44
Contributor
Author
xAI seems to be working well now |
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
enabled auto-merge
November 4, 2026 16:36
corbits-triage
Bot
added
Triage: Not Ready
and removed
Triage: Needs Human Review
labels
TheGreatAxios
force-pushed
the
cl-12085-give-each-writer-a-save-tool-for-just-its-own-document-so
branch
from
November 4, 2026 20:51
c827617 to
f5b0ddc
Compare
TheGreatAxios
changed the title
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/hub/src/projects/coordinator-upgrade.ts:441-450 promise-chain: Promise chain; use async/await with try/catch.apps/web/src/api/conversation.ts:51 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.apps/web/src/api/conversation.ts:52 empty-list-fallback: Invented fallback `?? []`; handle the missing value instead.
- Invented fallbacks: added code matches a code pattern
apps/hub/src/mail/conversation-routes.ts:135 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
TheGreatAxios
force-pushed
the
cl-12085-give-each-writer-a-save-tool-for-just-its-own-document-so
branch
from
November 4, 2026 21:56
f5b0ddc to
9447416
Compare
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/hub/src/mail/conversation-routes.ts:223-231 promise-chain: Promise chain; use async/await with try/catch.
- Invented fallbacks: added code matches a code pattern
apps/hub/src/mail/conversation-routes.ts:140 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.apps/hub/src/mail/conversation-routes.ts:214 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
TheGreatAxios
force-pushed
the
cl-12085-give-each-writer-a-save-tool-for-just-its-own-document-so
branch
from
November 4, 2026 22:04
9447416 to
4c6c4ca
Compare
|
Merged before Triage finished on |
Grok read the writer's four-kind union schema as having no fields and sent empty saves. Each document kind now has its own writer package whose write_artifact lists that kind's fields flat; the hub adds the kind.
Writers accept a kind matching their own, which models echo from the task. The scope keeps writer for non-coordinator bundles frozen before the split. deploy_writer offers only writer kinds, and each role's packages must share one offering to count as current.
Each writer package has its own key in the install record and project scope, so one key returns its deployment; a single package table maps each package to its role for build, install and upgrade. An unreadable install record now reinstalls the tenant instead of refusing every scope read, and the up-to-date check matches each package against its own offering. A contract test keeps the scope readable by specialists frozen on the last release.
TheGreatAxios
force-pushed
the
cl-12085-give-each-writer-a-save-tool-for-just-its-own-document-so
branch
from
November 4, 2026 22:33
4c6c4ca to
952ac67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12085
What changed
How it was verified