Repository navigation
fix: end the coordinator's turn when it replies after a restart - #136
Closed
TheGreatAxios wants to merge 2 commits into
Closed
TheGreatAxios wants to merge 2 commits into
TheGreatAxios wants to merge 2 commits into
Conversation
The reactor closes a message run right after it replies, and the page cleared "Thinking…" only on that close. A turn resumed from an approval restored after a restart has no message run, so it sends no close and the page stayed on "Thinking…" after the coordinator had replied. The page ends the live turn on the coordinator's reply as well.
The activity tracker marked the coordinator idle only on a message run ending. A turn resumed from an approval restored after a restart has no message run, so once it called a tool the hub kept reporting the coordinator as working after it replied, and a page opened later showed "Thinking…". The tracker ends the turn on the reply as well.
Contributor
Author
|
Superseded: the resumed turn is fixed in vendored Interchange instead (INTR-721), which reports the end of every resumed turn, so the page and hub need no reply rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run lint,format:check,typecheck,test(219 pass),pins:verifyandvendor:verifypass.Closes CL-12080