Repository navigation
feat(web): ask questions one at a time, with step tabs and keys - #131
Merged
TheGreatAxios merged 5 commits intoNov 4, 2026
Merged
TheGreatAxios merged 5 commits into
TheGreatAxios merged 5 commits into
Conversation
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/web/src/config.ts:965-969 nested-ternary: Nested ternary; use if statements or a lookup.apps/web/src/pages/workspace/questions-card.tsx:249-280 nested-ternary: Nested ternary; use if statements or a lookup.
- Invented fallbacks: added code matches a code pattern
apps/web/src/pages/workspace/questions-card.tsx:390 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
Contributor
Author
|
Screenshots from driving the real card in headless Chrome with key events (gist). Left: one at a time. Right: all at once. Enter picked "Just me" and moved on |
Contributor
Author
Contributor
Author
|
Updated screenshots after 228fc91: a done card now settles into a quiet box listing each answer, the same in both layouts. These replace the earlier comments. Both layouts, settled: identical Space ticks on a multi-choice question Submit lists every answer; the settled box uses the same list |
There was a problem hiding this comment.
Triage requests changes:
- Conventions: added code matches a code pattern
apps/web/src/config.ts:965-969 nested-ternary: Nested ternary; use if statements or a lookup.apps/web/src/pages/workspace/questions-card.tsx:116-120 nested-ternary: Nested ternary; use if statements or a lookup.apps/web/src/pages/workspace/questions-card.tsx:269-300 nested-ternary: Nested ternary; use if statements or a lookup.
- Invented fallbacks: added code matches a code pattern
apps/web/src/pages/workspace/questions-card.tsx:410 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
dismissed stale reviews from themself
November 4, 2026 06:19
Nothing triage asked to change still fails, so this request no longer stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.















Summary
first_versionreads "First version"), end in Submit and follow the person; a tab opens once reached and is checked once passed.ask_questionscontract is unchanged.Verification
bun run lint,format:check,typecheck,testpass.questions-card.test.tsx; composer placeholder test for open questions.Notes
GateBlockhas no option for it; its accessible name still reads "Needs you · form".Closes CL-12074