Repository navigation
fix(hub): show an approval decision once instead of as raw JSON - #130
Merged
TheGreatAxios merged 2 commits intoNov 4, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
TheGreatAxios
force-pushed
the
cl-12071-show-an-approval-decision-once-instead-of-as-raw-json-from
branch
from
November 4, 2026 05:52
aed2038 to
da2694f
Compare
TheGreatAxios
marked this pull request as ready for review
November 4, 2026 05:52
Interchange resumes a tool waiting on the person's approval with the
decision as JSON, sent from signal@local, and stores it in the
coordinator's conversation. The conversation mirror kept every inbound
message not sent by a run as the person's words, so the page showed
{"outcome":"approved"} under the approval card that already shows it.
For the page the mirror keeps only a note the person wrote with the
decision. A resumed coordinator has no card, so its held context reads
each decision as a plain line instead of the JSON.
TheGreatAxios
force-pushed
the
cl-12071-show-an-approval-decision-once-instead-of-as-raw-json-from
branch
from
November 4, 2026 06:01
da2694f to
1bd1056
Compare
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
dismissed
their stale review
November 4, 2026 06:14
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signal@local, bodyApprovalDecisionJSON) instead of reading it as the person's words.Approved a request.,Rejected a request: <note>).Verification
bun run lint,format:check,typecheck,test(219 pass),pins:verifyandvendor:verifypass; CI'se2eande2e-pipelinepass.origin/main.origin/main: a self-hosted run's stored conversation returns{"outcome":"approved"}as a person turn.Closes CL-12071