Repository navigation
fix(coordinator): ask through ask_questions and say its card sits below - #129
Merged
TheGreatAxios merged 11 commits intoNov 4, 2026
Conversation
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
There was a problem hiding this comment.
Triage requests changes:
- Errors kept: added code matches a code pattern
apps/web/src/pages/workspace/visible-chat.ts:152-154 bare-catch: A catch without a binding drops the error; check for the expected failure, or catch it and rethrow the rest.
- Invented fallbacks: added code matches a code pattern
apps/web/src/pages/workspace/visible-chat.ts:145 empty-fallback: Invented fallback (an empty string, list, object or zero); handle the missing value instead.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
dismissed
their stale review
November 4, 2026 06:22
Nothing triage asked to change still fails, so this request no longer stands.
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
TheGreatAxios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask_questionscall; the opening broad question stays in the reply. The per-step caps, ordering and preselect guidance are gone; the schema's limit of five stays.The written-JSON fallback first built here is removed: no stored run shows the model writing questions as JSON, and each review round found new edge cases. Its code, tests and notes are kept in Shelved: written ask_questions JSON fallback on CL-11868.
Verification
bun run lint,format:check,typecheck,test(227 pass).Closes CL-11868