Skip to content

fix(web): subscribe to a project's runs under the project's tenant - #125

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-12055-stream-the-coordinators-replies-live-instead-of-waiting-for
Nov 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-12055-stream-the-coordinators-replies-live-instead-of-waiting-for

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The project page subscribes to the coordinator run's live stream under the project's own tenant, so the hub's stream route finds the run.
  • A live coordinator turn held on an approval its own run raised is not marked as streaming, so its header shows the finished summary instead of "Working…" above the approval card.

Verification

  • bun run lint, format:check, typecheck, test (218 pass), pins:verify and vendor:verify pass; CI's e2e and e2e-pipeline pass.
  • On a self-hosted run the stream request returns 200 (404 on main).
  • A test folds a run parked on request_approval: not streaming while the coordinator's own approval is open; streaming when only another run's approval is open, or none.

Closes CL-12055

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

CL-12055

@TheGreatAxios
TheGreatAxios force-pushed the cl-12055-stream-the-coordinators-replies-live-instead-of-waiting-for branch 2 times, most recently from e0f845f to ad8e178 Compare November 4, 2026 05:30
Each project is its own tenant beneath the workspace, and its runs live
there. The project page subscribed to the coordinator run's live stream
under the workspace's tenant, so the hub found no run and answered 404
on every attempt: no reply streamed in, and the page never saw a turn
end. The page subscribes under the tenant of the project it already
reads for its lifecycle.
A run held on the person's approval keeps its message run open, and
with the live stream connected the page kept the coordinator's turn
marked as streaming: its header read "Working…" above the approval
card. A live turn held on an approval the coordinator raised is not
streaming, so its header shows the finished summary.
@TheGreatAxios
TheGreatAxios force-pushed the cl-12055-stream-the-coordinators-replies-live-instead-of-waiting-for branch from ad8e178 to 67681a4 Compare November 4, 2026 05:50
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 4, 2026 05:51
@corbits-triage

corbits-triage Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Notes:

  • mixes unrelated changes

Triage will approve, request review, label.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit d62f953 Nov 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant