Repository navigation
fix(web): let the page show blob: images, so attached pictures get thumbnails - #116
Merged
Merged
Conversation
…umbnails The attachment components preview a picture from an object URL, which is a blob: URL the page's Content Security Policy did not allow, so every attached picture showed as its type instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
What
The page's Content Security Policy allows
blob:images, so a picture attached to a message shows as a thumbnail.Why
The attachment components in
@corbits/react-uipreview a picture from an object URL made withURL.createObjectURL, ablob:URL. The policy inapps/web/index.htmlallowed'self'anddata:only, so the browser blocked every preview and the kit fell back to the file's type. Details in #117.Changes
apps/web/index.html:img-srcgainsblob:.