Repository navigation
fix(web): follow the coordinator's reply to its end after the person sends - #108
Merged
Merged
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
What
After the person sends a message, the conversation follows the coordinator's reply to its end and keeps following as it grows, until the person scrolls away.
Why
The thread used the conversation component's default
settlepolicy: the sent message glides to the top of the view and the reply writes in below it, with the view held still while it streams. A reply longer than the view ran off the bottom, and the person had to scroll to read it or to see it end. Details in #107.Changes
apps/web/src/pages/workspace/transcript.tsx: the thread'sConversationtakesscrollPolicy="stick". A send glides the view to the end and follows new content; only the reader's own scrolling breaks the follow, and the existing scroll button brings them back.