Skip to content

chore(lint): cap function complexity, parameters and callback nesting - #10

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11853-cap-function-complexity-parameters-and-callback-nesting-in
Oct 31, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11853-cap-function-complexity-parameters-and-callback-nesting-in

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11853 (https://linear.app/abklabs/issue/CL-11853/cap-function-complexity-parameters-and-callback-nesting-in-lint).

Changes

  • .oxlintrc.json now fails code over these limits:
    • complexity 40 (eslint/complexity)
    • 6 parameters (eslint/max-params)
    • 5 nested callbacks (eslint/max-nested-callbacks)
  • The 7 files over a limit today are exempt from that rule only, through overrides:
    • complexity: the agent token bridge, App.tsx and three workspace pages
    • parameters: the artifacts service and project routes
  • Each file comes off its list when it's cleaned up. Every other file is held to the limits now, and nothing is exempt from the callback limit.

Verification

  • bun run lint passes.
  • A temporary function with 7 parameters and 6 nested callbacks fails both rules. It was removed afterwards.
  • An independent review found vendor files in the exception list (vendor is never linted); they're removed.

@linear-code

linear-code Bot commented Oct 31, 2026

Copy link
Copy Markdown

CL-11853

@corbits-triage

corbits-triage Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve.

@TheGreatAxios
TheGreatAxios force-pushed the cl-11853-cap-function-complexity-parameters-and-callback-nesting-in branch from e12731c to f13328d Compare October 31, 2026 08:54
@TheGreatAxios
TheGreatAxios merged commit f13328d into main Oct 31, 2026
7 checks passed
@TheGreatAxios
TheGreatAxios deleted the cl-11853-cap-function-complexity-parameters-and-callback-nesting-in branch October 31, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant