Skip to content

Address pre-publish review findings for corbits-artifacts - #11

Merged
TheGreatAxios merged 3 commits into
mainfrom
cl-8193-address-pre-publish-review-findings-for-corbits-artifacts
Sep 21, 2026
Merged

TheGreatAxios merged 3 commits into
mainfrom
cl-8193-address-pre-publish-review-findings-for-corbits-artifacts

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary
Address the pre-publish review findings (CL-8193): npm-first install docs, @intX floor at 0.3.0 everywhere stated, reference-host pins at 0.3.0, CHANGELOG 0.1.0 as its own release section, no workspaces in the published manifest, package author set.

Verification

  • bun run typecheck: pass
  • bun run build: pass
  • bun run pretest: pass (no @workbench imports)
  • bun test src/destructive-tests-gate.test.ts: 12 pass, 0 fail
  • bun test src: 58 pass, 183 fail — all failures are the fail-closed destructive-test gate (no opt-in env flag set); DB-backed suites need ARTIFACT_DATABASE_URL plus ALLOW_DESTRUCTIVE_ARTIFACT_TESTS=1
  • npm pack --dry-run: tarball corbits-artifacts-0.1.0.tgz, 73 files, zero examples/ entries

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Review

Verdict: request changes (rebase before merge). GitHub says MERGEABLE but the branch is 8 behind. No prior reviews.

Intent is still live on main (workspaces, git-first README, peers already ^0.3.0 while docs say 0.2.2). bun.lock is rewritten here and a new examples lockfile is added — CI did not prove a merge against #15–#19.

Should-fix: CHANGELOG rewrites historical 0.1.0 notes to require intx 0.3.0. Floor bump belongs in Unreleased / 0.2.x, not backdated 0.1.0.

@TheGreatAxios
TheGreatAxios force-pushed the cl-8193-address-pre-publish-review-findings-for-corbits-artifacts branch from 9f8d332 to 7d3bb5a Compare September 21, 2026 01:42
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Re-review

Verdict: approve. SHA 7d3bb5a on current main.

CHANGELOG: intx 0.3 under Unreleased; 0.1.0 still 0.2.2. Git install. typecheck + pretest + destructive-tests-gate 12 pass.

@TheGreatAxios
TheGreatAxios merged commit ce9d0ff into main Sep 21, 2026
1 check failed
@TheGreatAxios
TheGreatAxios deleted the cl-8193-address-pre-publish-review-findings-for-corbits-artifacts branch September 21, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant