Develop v4#606
Merged
Merged
Conversation
…aversal The unload event is deprecated in modern browsers (suppressed since Chrome 115+ for BFCache compatibility) and was used to notify the parent frame when a user navigates to a new page in the live preview iframe. Replaced with the pagehide event, which is the browser-recommended drop-in replacement — it fires in the same scenarios without blocking BFCache. Also deleted src/utils/handlePageTraversal.ts which was dead code (not imported anywhere) but also contained a deprecated unload listener. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: fixed the sideEffect issue due to setConfigFromParams
fix: added update to stop the double firing of init in vb
Vb 1504 remaining gaps
Address PR review feedback: the visualBuilderPostMessage send in setPageContext was fire-and-forget, so a rejected promise would surface as an unhandled rejection. Add a .catch that logs the failure via PublicLogger.error. Also add setPageContext test coverage for the Config write, the in-iframe send, the non-iframe skip, and the new send-failure path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…r-for-custom-url feat: add page context helper for custom URL handling in Visual Builder
…nload-event-listeners fix(VP-556): replace deprecated unload event with pagehide in page traversal
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.