feat: upstream all changes from constructive-db main#75
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Syncs deploy/revert/verify source files from constructive-db, excluding internal-only modules (node_type_registry). Key changes: Provision fixes: - SECURITY DEFINER on partman wrappers (create_parent_with_retention, run_maintenance_by_id) for pg_partman 5.x SET ROLE privilege fix - Extended partman schema grants (USAGE, CREATE, table DML, ALTER DEFAULT PRIVILEGES) - Partition table added to metaschema-schema (deploy/revert/verify + pgpm.plan) Other upstream changes: - database-jobs: organization_id + entity_type columns on jobs table and add_job - metaschema-modules: agent_module → agent_chat_module rename, removed deprecated modules (config_secrets_org, graph, merkle_store, session_secrets), verify fixes - object-tree: revert script fix All SQL packages regenerated as 0.26.1.
devin-ai-integration
Bot
force-pushed
the
feat/upstream-from-constructive-db
branch
from
1a752c9 to
5e8a4ce
Compare
…snapshot - Restored DROP FUNCTION set_props_and_commit in object-tree revert (needed for clean schema drop during integration tests) - Updated database-jobs snapshot to include organization_id and entity_type columns
Verify files for tables where only the verify (not deploy) changed from constructive-db were restored to pgpm-modules main versions. These verify files reference columns that don't exist in the pgpm-modules deploy. Restored: secure_table_provision, relation_provision, blueprint, compute_log_module, db_usage_module, inference_log_module, profiles_module, storage_log_module, transfer_log_module verify files. Also restored object-tree set_and_commit revert (needed for integration test). Regenerated SQL packages.
Constructive-db removed revert/verify files for modules it considers deprecated, but pgpm-modules still has them in the plan and deploys them. The integration test runs deploy→verify→revert and needs all three files. Restored: agent_module, config_secrets_org_module, entity_type_provision, graph_module, merkle_store_module, session_secrets_module revert+verify files. Removed orphaned agent_chat_module files (not in pgpm.plan).
constraintCount changed from 394604 to 396560 due to new columns in namespace_module and other deploy changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs deploy/revert/verify source files from
constructive-dbmain (post-merge of #1388), excluding internal-only modules (node_type_registry). Preserves pgpm-modules versioning (bumped to 0.26.1).Provision fixes (from constructive-db #1388):
create_parent_with_retention,run_maintenance_by_id) — fixes pg_partman 5.xSET ROLE 'postgres'privilege limitationUSAGE, CREATE, table DML,ALTER DEFAULT PRIVILEGESmetaschema-schema(deploy/revert/verify + pgpm.plan entry)Other upstream changes:
database-jobs:organization_id+entity_typecolumns on jobs table andadd_jobmetaschema-modules: deploy changes for agent_module, config_secrets_user_module, entity_type_provision, function_module, memberships_module, merkle_store_module, namespace_module, storage_moduleobject-tree: revert script preservedExcluded from upstream:
node_type_registry— internal to constructive-dbAll SQL packages regenerated as 0.26.1.
Review & Testing Checklist for Human
node_type_registryis NOT included (it's internal to constructive-db)organization_idandentity_typecolumnsNotes
namespace_moduledeploy has structural changes (addedkeycolumn, removed some columns, changed unique constraint)"Link to Devin session: https://app.devin.ai/sessions/ef81e3515d464727a7fad3187bbceaca
Requested by: @pyramation