fix(codegen): use .targets manifest for stale target cleanup#1257
Merged
Conversation
removeStaleTargetDirs now reads a .targets manifest (written by generateMulti after successful output) to know which directories were previously generated. Only those are eligible for removal. Hand-written directories like config/ and utils/ are never touched.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeStaleTargetDirswas deleting every subdirectory not in the current target list — including hand-written dirs (config/,utils/) that aren't codegen targets. This brokeconstructive-cliduring schema propagation.Fix:
generateMultinow writes a.targetsmanifest (JSON array of target names) to the output root after successful generation.removeStaleTargetDirsreads this manifest to scope deletions — only directories listed in the previous manifest but absent from the current target list are removed. Dirs not in the manifest (hand-written code) are never touched.On the first run after this lands, no manifest exists yet → nothing gets cleaned (safe, codegen overwrites its own output anyway). Subsequent runs work correctly.
Link to Devin session: https://app.devin.ai/sessions/e3d4f66d70624516b67179748093d772
Requested by: @pyramation