feat: add is_dumb public function#290
Open
ugur-eren wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add public
is_dumb()functionExposes a new public function
is_dumb()that provides a fast way to check whether the application has a "dumb" terminal (i.e.TERMis unset or set todumbon Unix;TERMexplicitly set todumbon Windows).This logic previously existed only as an inline check inside
is_a_color_terminal(). This PR extracts it into a dedicatedis_a_dumb_terminal()function per platform (unix_term.rs,windows_term/mod.rs,wasm_term.rs), and wires it up through a new publicis_dumb()interm.rs, re-exported fromlib.rs.Behavior
No change to existing
is_a_color_terminal()output. This is a pure refactor for that path. New behavior is only the addition of the standaloneis_dumb()API.Note
is_dumb()semantics differ slightly by platform whenTERMis unset (Unix treats unset as dumb but Windows does not, since native Windows terminals typically don't setTERM).This is intentional and documented on the function.
This PR is in relation to conversation on PR console-rs/indicatif#808