Skip to content

Cover proptest-only scanner and preprocessor paths deterministically - #9

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
upstream/deterministic-coverage
Oct 22, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
upstream/deterministic-coverage

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

Six production lines were reached only by the unseeded proptest cases, so whether each run covered them was a matter of chance. Codecov's project check flipped with it, and it failed on the lockfile-only refresh in #8 although preprocessor.rs never touches sqlparser.

These tests pin the behaviour behind those lines. An unterminated string or block comment runs to the end of the text, a digit-led $1$ is a placeholder and opens no dollar quote, and a bare qualifier such as rec. before := or = is left for the parser instead of being refused as a qualified assignment. With the property tests switched off the six lines stay covered, so the coverage figure no longer depends on the random draw.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d18cfa15-fbca-40df-bf46-3913e635500f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (427ebea) to head (e68eb02).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   98.43%   98.59%   +0.15%     
==========================================
  Files           4        4              
  Lines        1408     1422      +14     
==========================================
+ Hits         1386     1402      +16     
+ Misses         22       20       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 merged commit 016542b into main Oct 22, 2026
11 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the upstream/deterministic-coverage branch October 22, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant