Repository navigation
Keep the name of a foreign key written inline on its column - #176
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CREATE TABLE child (parent_id INT CONSTRAINT fk_parent REFERENCES parent (id))reported a foreign key with no name, while PostgreSQL names itfk_parentand the table-constraint spelling already reads back asfk_parent. sqlparser keeps the name of an inline constraint on the column option and leaves the constraint itself unnamed, and the inline foreign key arm never copied it across, which the inlineUNIQUEarm already does.The same change was merged as #173, but into the stacked base of #172 after #172 had already been squashed into
main, so it never reachedmain.