[LucaCappelletti94]

sql-traits dropped CREATE FOREIGN TABLE without recording anything, so a schema that also granted on the foreign table failed to load with TableNotFoundForGrant. A foreign table is a relation in PostgreSQL (relkind f) that never carries row-level security, which makes a grant on it a full read of the remote relation, so a linter needs to see both the table and its grants.

The foreign table now goes into its own foreign_tables() pool beside tables(), which keeps answering only for relations that store their own rows, so callers asking about primary keys or row-level security on tables do not start seeing foreign tables. It uses the same node type as a table, so its columns, checks, owner, triggers and grants come from the existing table machinery. TableLike::foreign_source returns its SERVER and OPTIONS, and ColumnLike::foreign_options returns a column's own OPTIONS with keys folded as PostgreSQL stores them in attfdwoptions. Relation gains a ForeignTable variant, so grants, relation lookups and the relations a statement reads name it as its own kind, and ALL TABLES IN SCHEMA covers foreign tables as it does in PostgreSQL.

Ingestion follows what PostgreSQL 17 and 18 accept and refuse on a foreign table. ALTER TABLE column, rename and owner actions, triggers, LIKE, INHERITS in either direction, DROP FOREIGN TABLE and ATTACH PARTITION work on it, and partitions() and inheritors() list it. Column options stay with the column that declares them, so an inheriting table or a column added through a parent gets none. Key constraints, indexes, references to it, policies, row-level security and persistence changes, rules, DROP TABLE, and a unique index reaching it through a partitioned table are refused with the relation named as a foreign table, as are column OPTIONS on an ordinary table and an option list naming the same key twice. RuleOnMaterializedView and RuleOnSequence become RuleOnUnsupportedRelation so the rule refusal can name any of these kinds.

ALTER FOREIGN TABLE and CREATE FOREIGN TABLE ... PARTITION OF still wait on apache/datafusion-sqlparser-rs#2745 and #2753.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.

• group context tests/function_referenced_tables.rs:507-517 function_referenced_tables::named_by

echoes · 👎 Report a wrong review · ❤️ Support echoes