Repository navigation
Refuse arrays whose elements are stored as BLOB - #173
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
ArrayRepresentation::Jsonthe replica builds every array withjson_arrayorjson_group_arrayover the translated elements, and SQLite refuses a BLOB argument to both withJSON cannot hold BLOB values. ABYTEA[]column, aUUID[]column underUuidRepresentation::Blobor avector(n)[]column translated without complaint and then failed on the first write of a non-empty array, andARRAY[b]orarray_agg(u)over such columns failed on the first row.An array type is now refused when its element type translates to
BLOB, in the same placeNUMERIC(p,s)[]is refused, which covers column declarations and casts. TheARRAY[...]constructor,array_agg,array_append,array_prepend,||with a lone element and the replacement value ofarray_replacerefuse an element whose declared or cast type is stored as a BLOB, with the same message. A function returning a BLOB is not typed here and still fails in SQLite.UUID[]underUuidRepresentation::Textkeeps working.json_agg,json_build_arrayand the other JSON functions hit the same SQLite error over BLOB columns, but PostgreSQL gives them a text answer, so they need a translation and are out of scope here. The commit also dropsREVOKE role FROM rolelikeGRANT role TO role, since sqlparser main now parses it as its ownRevokeRolestatement. It builds against connetto-rs/sql-traits#172, which sqlparser main needs as well.