Skip to content

Handle sqlparser table membership and statement variants - #161

Merged
LucaCappelletti94 merged 2 commits into
mainfrom
upstream/sqlparser-main-ast-compatibility
Oct 25, 2026
Merged

LucaCappelletti94 merged 2 commits into
mainfrom
upstream/sqlparser-main-ast-compatibility

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

Tracking sqlparser/main leaves the library unable to compile because the exhaustive matches do not cover its table-membership target and PostgreSQL statement additions.

The handling follows the existing semantic contract. Foreign-data definitions retain their warned-drop policy, while rules and trigger alterations receive explicit refusals because dropping them would discard behavior. SQLite table-membership shorthand also receives a refusal because PostgreSQL requires an explicit subquery.

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working rust Pull requests that update rust code labels Oct 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/impls/expr_helpers.rs 93.33% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These duplicates are not on lines GitHub shows in this pull request diff, the inline comment cannot attach there. The links point at the copies on the head commit.

@LucaCappelletti94
LucaCappelletti94 merged commit eaa8095 into main Oct 25, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant