Repository navigation
Cover a role in a second main file initialization - #151
Merged
Merged
Conversation
LucaCappelletti94
force-pushed
the
upstream/fresh-main-create-role-test
branch
from
October 24, 2026 17:14
d51fecb to
79c9282
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plain
CREATE ROLEused to makeFreshFiles::MainandFreshFiles::Attachedrefuse the whole script, because the replay applied the role again to a reference schema that already held it in its final form. #145 fixed that by keeping roles and functions final, and it shipped tests for the function case but none for roles. This test initializes a second main file next to an existing shared file for a script that creates a role and grants it on the placed table, and reads the rows of both files. Against the source before #145 it fails withRole reader already exists.