Conversation
iainmcgin
force-pushed
the
iain/commit-lockfile
branch
2 times, most recently
from
September 6, 2026 16:41
5aafce6 to
60202a8
Compare
A dependency release could change what CI built overnight: the generated-code check resolved the newest buffa at run time and failed on every PR once buffa 0.9.2 changed codegen output, and the MSRV job is exposed the same way to any transitive MSRV bump. Committing the workspace lockfile and passing --locked in every CI cargo invocation makes a dependency bump an explicit PR instead. The generated-code job now builds the buffa plugins from the tag matching the locked version, so a buffa bump and its regenerated code travel together. Two companions keep the lock honest: a weekly Dependabot group PR for semver-compatible updates, and a scheduled "Latest dependencies" workflow that runs the tests after a fresh `cargo update`, which is what downstream crates resolve. The lockfile has no effect on those crates; Cargo ignores a dependency's lockfile. Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
iainmcgin
force-pushed
the
iain/commit-lockfile
branch
from
September 11, 2026 22:24
60202a8 to
d02a3c8
Compare
iainmcgin
marked this pull request as ready for review
September 11, 2026 22:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #294 (the first commit here is that PR; this one rebases onto main once it lands).
With no committed lockfile, a dependency release changed what CI built overnight: the generated-code check resolved the newest buffa at run time and has failed on every PR since buffa 0.9.2 changed codegen output on 2026-09-03, and the MSRV job is exposed the same way to any transitive MSRV bump. This commits the workspace
Cargo.lock(resolved against crates.io today, buffa 0.9.2) and builds CI with--locked(the example scripts andtask generate:alladd it whenCIis set), so a dependency bump becomes an explicit PR; the generated-code job builds the buffa plugins from the tag matching the locked version, so a buffa bump and its regenerated code have to travel together. Two companions keep the lock from going stale: a weekly Dependabot group PR for semver-compatible updates, and a scheduled Latest dependencies workflow that runs the tests after a freshcargo update, which is what a crate depending onconnectrpcresolves — the lockfile itself has no effect on those crates.--lockedalso passes on the 1.88 MSRV toolchain (lockfile format v4).Fixes #254 (the "related"
buf.gen.yamlsibling-checkout note there is not addressed).