Make bench CLI load TypeScript benchmarks - #346
Open
HeyGarrison wants to merge 4 commits into
Open
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor License AgreementAll contributors are covered by a CLA. |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
benchCLI couldn't execute the newbenchmarks/reliability/sandbox-opencode.bench.tsfile because plain Node doesn't resolve.tssource or its.js→.tsimports.packages/benchsdk-runner/src/bin.ts: registers thetsxESM loader at startup.packages/benchsdk-runner/package.json: addstsxas a runtime dependency and points thebenchbinary at the ESM build (./dist/bin.js) so the bin and any loaded TypeScript benchmark resolve the same@benchsdk/runnerinstance.package.jsonand.github/workflows/reliability-tensorlake-opencode.yml: switch the reliability benchmark back tobench run ....This removes the
tsx packages/benchsdk-runner/dist/bin.jsindirection.pnpm typecheck,pnpm --filter @benchsdk/runner test, and a drybench runof the reliability benchmark all pass (the run fails as expected with a dummyTENSORLAKE_API_KEY, but it loads the module and reaches the Tensorlake provider step).Link to Devin session: https://app.devin.ai/sessions/754c6cb646a146a0b6c883eae4b613b1
Requested by: @HeyGarrison