Enable precompute embeddings CLI using SAM2 models#1237
Draft
anwai98 wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
I didn't port the CLI tests, they would break. Need a few minutes! |
Collaborator
Author
|
Lemme come back to this after the package refactor then. Doesn't make sense to fix it in chunks! |
Collaborator
Author
|
I realized this was a rooky move. I should align backend separation first. I'm gonna convert this to a draft PR and come back to this later! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards making SAM2 3d segmentation more modular, and slowly replacing CLIs to support
micro-sam2.I rushed in here a bit, lemme do things properly!