Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompilingMatchercaches match results but currently builds a combined string key on every call, even when the result is already cached.For example, checking whether
2.1.0satisfies>=2.0.0:Checking the same constraint against
2.2.0etc. repeats this work, including concatenating the unchanged operator and constraint.This PR stores results in nested arrays instead:
Each call accesses the operator/constraint bucket by reference, then looks up the version within it. This avoids constructing the combined string key over and over again.
The reference bit might look strange at first, that's why I've added a comment explaining it. It basically lets the lookup and any subsequent write reuse the same bucket and it has a measurable positive impact on performance.
On a real project's
composer update, pool optimization took 678 ms instead of 723 ms (~6% faster) so really this complexity is all about optimizing the hot path 😊