Repository navigation
Make research topic chips keyboard-reachable teal buttons - #151
Conversation
Topic filters were purple spans, so the keyboard and the teal accent never reached them. Real buttons keep the same tag filter and expose pressed state. Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The button path left the span keyboard fallback untested, which dropped statement coverage under the 80 percent gate. Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
@coderabbitai review |
|
comphy-bot review status for Review completed for this exact pull request head. |
comphy-bot
left a comment
comphy-bot
left a comment
There was a problem hiding this comment.
Review: Make research topic chips keyboard-reachable teal buttons
Reviewed +166/-95 across 12 files at 3501c0ec43968ce5ccac9ab532095c9be906c48d.
No P0/P1 findings. The native-button migration is consistent across the research markup, filtering selectors, command-palette integration, tag-page discovery and featured-card styling. Pressed state is synchronized on activation and reset, while legacy spans retain their keyboard handling. No actionable security or complexity regression identified in the changed paths.
Verification: exact-head build, content-rules and PR-hygiene checks succeeded; deployment was skipped. Deterministic patch checks passed. Reviewed the updated filtering, deep-link, legacy-span and command-palette test changes statically; no PR code or test scripts were executed during this review. Native Enter/Space activation and visual focus/contrast were not independently exercised in a browser.
No peer review threads contained findings in the complete review snapshot.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 6 files. (6 skipped: 6 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: making research topic chips keyboard-reachable teal buttons. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 6 files. (6 skipped: 6 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
ESLint install timed out. The project may have too many dependencies for the sandbox.
Comment @coderabbitai help to get the list of available commands.
Summary
The topic filters on
/research/look clickable, but they are purple<span>chips. In dark mode the label is the raw#d99adcpurple, and the spacing is raw pixels. A keyboard user cannot treat them as real controls, and the design system reserves teal (--c-accent-teal) for interactive accents. These chips are now<button type="button">elements, styled only from tokens, witharia-pressedfor the active filter. Enter and Space still filter the same tag list, including the?tag=deep link.Changes
_research/index.mdare buttons. Citation headings are unchanged.--c-accent-teal,--s-*,--t-*, and--r-pill. Hover, selected, and:focus-visiblestates use that teal. The dark-mode#d99adcoverride is gone.page-research.jssetsaria-pressedon the active filter and still toggles the same papers. The command palette and the tag-page generator read both buttons and any leftover spans.Testing
./scripts/lint-check.shnpm test(28 suites, 214 tests)npm run lint(existing warnings only, insearch-manager.jsandutils.js)./scripts/build.sh(Jekyll, 26 tag redirect pages, SEO metadata)?tag=Bubbles,aria-pressed="true", and hides non-matching papers (12 visible, 18 hidden). Space clears the filter. Tab moves to Drops. Focus ring is4px solidteal (rgb(37, 76, 74)light,rgb(106, 194, 189)dark). Before shots are the live site, where the same chip is a span in brand purple, dark labelrgb(217, 154, 220).Screenshots
Before, live
/research/:After, local build:
Summary by CodeRabbit