Repository navigation
Restyle /research and /join body panels onto the design system - #144
Merged
Merged
Conversation
The leftover styles.css glass box used a 10px radius, a cool white or #1e1e1e fill, and purple/blue headings. /join now uses the .panel surface, border, radius, and shadow tokens. /research drops that outer box because the publication list already sits on paper. Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
Contributor
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 49 minutes. View limit details
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The body panels
.research-contenton/researchand.join-contenton/joinstill used leftoverstyles.csschrome: a 10px radius, a legacy shadow, and a cool fill (rgba(255,255,255,0.25)in light,rgba(30,30,30,0.4)in dark) instead of the warm paper family./joinalso kept a purpleh1and blueh2s./joinnow uses the design-system.panelsurface, border,--r-lgradius, and shadow tokens in both themes, with in-panel headings on--fg-strongat--t-weight-semi./researchdrops that outer box instead: the publication list already sits on--c-paperbeside a TOC and year rules, so a second glass rectangle was a frame around a frame. The in-bodyResearchh1in_research/index.mdis left alone and stays visible in ink.Type of Change
Changes
assets/css/join-us.css: restyle.join-contentwith--c-surface-glass,--c-border,--r-lg,--shadow-soft. Headings inside the panel use--fg-strong/--t-weight-semi. Internships blockquote colour from Fix internships callout contrast in dark mode on /join #125 and.card/.panel/.btncards from Rebuild /join project and position cards on the design system #128 are unchanged.assets/css/research-v2.css: reset leftover glass chrome on.research-content(transparent, no radius, no shadow). Restyle the in-bodyh1to--fg-strongwithout hiding it.tokens.cssand_research/index.mdare not edited.Testing
npx prettier --checkon the two CSS filesnpx stylelinton the two CSS files./scripts/lint-check.sh(pass; pre-existing ESLint warnings only)npm test -- --runInBand(210 tests passed)bundle exec jekyll buildfor before (/tmp/comphy-site-before) and after (/tmp/comphy-site-after)/researchand/join, light and dark, 1440 and 390Computed styles (after):
/join.join-contentrgba(255,253,249,0.72), 28px,--shadow-softrgba(43,37,29,0.78), 28px,--shadow-soft/joinh1/h2#0f0c08/ 600#f8f4ec/ 600/joininternships quote#625648on panel#e6dfd0on panel/join.project-card#fffdf9, 18px#2b251d, 18px/research.research-content/researchin-bodyh1#0f0c08/ 600,display:block#f8f4ec/ 600,display:blockGitHub on
3d05a15:build: successPR hygiene — dependency/security separation: successdeploy: skipped onpull_requestScreenshots
/research, desktop 1440
Before (light)

After (light)

Before (dark)

After (dark)

/research, mobile 390
Before (light)

After (light)

Before (dark)

After (dark)

/join, desktop 1440
Before (light)

After (light)

Before (dark)

After (dark)

/join, mobile 390
Before (light)

After (light)

Before (dark)

After (dark)

/join internships callout (kept from #125 / #128)
After (light, 1440)

After (dark, 1440)

Related Issues
Live design audit of comphy-lab.org, 12 Oct 2026, finding 3. Sister work: internships callout #125, join cards #128. The duplicate Research h1 in
_research/index.mdis left for Coulomb (#141).Checklist