Skip to content

Restyle /research and /join body panels onto the design system - #144

Merged
VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/research-join-panel-chrome-c22d
Oct 12, 2026
Merged

VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/research-join-panel-chrome-c22d

Conversation

@VatsalSy

@VatsalSy VatsalSy commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Summary

The body panels .research-content on /research and .join-content on /join still used leftover styles.css chrome: a 10px radius, a legacy shadow, and a cool fill (rgba(255,255,255,0.25) in light, rgba(30,30,30,0.4) in dark) instead of the warm paper family. /join also kept a purple h1 and blue h2s.

/join now uses the design-system .panel surface, border, --r-lg radius, and shadow tokens in both themes, with in-panel headings on --fg-strong at --t-weight-semi. /research drops that outer box instead: the publication list already sits on --c-paper beside a TOC and year rules, so a second glass rectangle was a frame around a frame. The in-body Research h1 in _research/index.md is left alone and stays visible in ink.

Type of Change

  • Bug fix
  • New feature
  • Content update (Team/Publication)
  • Documentation update
  • Other (please describe)

Changes

Testing

  • npx prettier --check on the two CSS files
  • npx stylelint on the two CSS files
  • ./scripts/lint-check.sh (pass; pre-existing ESLint warnings only)
  • npm test -- --runInBand (210 tests passed)
  • bundle exec jekyll build for before (/tmp/comphy-site-before) and after (/tmp/comphy-site-after)
  • Chromium against those builds: /research and /join, light and dark, 1440 and 390

Computed styles (after):

Surface Light Dark
/join .join-content rgba(255,253,249,0.72), 28px, --shadow-soft rgba(43,37,29,0.78), 28px, --shadow-soft
/join h1 / h2 #0f0c08 / 600 #f8f4ec / 600
/join internships quote #625648 on panel #e6dfd0 on panel
/join .project-card #fffdf9, 18px #2b251d, 18px
/research .research-content transparent, 0 radius, no shadow same
/research in-body h1 #0f0c08 / 600, display:block #f8f4ec / 600, display:block

GitHub on 3d05a15:

  • build: success
  • PR hygiene — dependency/security separation: success
  • deploy: skipped on pull_request
  • CodeRabbit check: success, description "Review rate limited"; 0 unresolved threads. The App did not review this range. Local CodeRabbit CLI was not installed.
  • Copilot: quota limit on this user; no review posted.

Screenshots

/research, desktop 1440

Before (light)
Research before, desktop 1440 light

After (light)
Research after, desktop 1440 light

Before (dark)
Research before, desktop 1440 dark

After (dark)
Research after, desktop 1440 dark

/research, mobile 390

Before (light)
Research before, mobile 390 light

After (light)
Research after, mobile 390 light

Before (dark)
Research before, mobile 390 dark

After (dark)
Research after, mobile 390 dark

/join, desktop 1440

Before (light)
Join before, desktop 1440 light

After (light)
Join after, desktop 1440 light

Before (dark)
Join before, desktop 1440 dark

After (dark)
Join after, desktop 1440 dark

/join, mobile 390

Before (light)
Join before, mobile 390 light

After (light)
Join after, mobile 390 light

Before (dark)
Join before, mobile 390 dark

After (dark)
Join after, mobile 390 dark

/join internships callout (kept from #125 / #128)

After (light, 1440)
Join internships after, desktop 1440 light

After (dark, 1440)
Join internships after, desktop 1440 dark

Related Issues

Live design audit of comphy-lab.org, 12 Oct 2026, finding 3. Sister work: internships callout #125, join cards #128. The duplicate Research h1 in _research/index.md is left for Coulomb (#141).

Checklist

  • Code follows the project's style guidelines
  • All links are valid and working
  • Images are optimized and properly sized
  • Content is properly formatted
  • Documentation has been updated (if needed)
  • Changes have been tested locally
  • This PR is single-purpose and does not mix dependency/security updates with unrelated formatting or content cleanups
  • All review threads are resolved or have an explicit won't-fix / follow-up disposition before merge
  • Every accepted review finding that identifies a reproducible bug or edge case either lands a regression test in this PR or has a linked follow-up issue referenced in the thread resolution
Open in Web Open in Cursor 

The leftover styles.css glass box used a 10px radius, a cool white
or #1e1e1e fill, and purple/blue headings. /join now uses the .panel
surface, border, radius, and shadow tokens. /research drops that
outer box because the publication list already sits on paper.

Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
Copilot AI balanced review requested due to automatic review settings October 12, 2026 09:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 29 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 04894a9c-a1b5-4535-a291-b45939ef03a4

📥 Commits

Reviewing files that changed from the base of the PR and between 2711e98 and 3d05a15.


📒 Files selected for processing (2)
  • assets/css/join-us.css
  • assets/css/research-v2.css

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@VatsalSy
VatsalSy merged commit 1555d9d into main Oct 12, 2026
4 checks passed
@VatsalSy
VatsalSy deleted the rayleigh-cloud/research-join-panel-chrome-c22d branch October 12, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants